ui/ui/src/components/devices/AddBridgeDialog.tsx (1)

167-173: Clean up commented-out debug log

The commented console.log is no longer used; consider removing it (or switching to a structured logging mechanism) to avoid accumulating dead debug code in the component.

backend/control_center/.env.example (1)

49-53: DOCKER_IMAGE default looks good; add trailing newline for linter

Setting DOCKER_IMAGE=taurinetech/sdn-launch-control-backend:latest aligns the example with the published image; that part looks fine.
To satisfy dotenv-linter’s EndingBlankLine warning, add a blank newline at the end of the file.

backend/control_center/ansible/roles/ovs-cleanup-port-setup/tasks/cleanup_port_setup.yml (1)

19-69: Cleanup flow is consistent; consider optional hardening

The interface-monitor cleanup sequence (stop/disable timer → remove unit files/logrotate → remove directory and logs → daemon_reload) is coherent and mirrors the setup role nicely. Two optional tweaks you might consider:

• Also stop the interface-monitor.service explicitly, in case a run is in progress during cleanup.
• Narrow ignore_errors if you ever want to surface genuine failures (e.g., permission issues) rather than swallowing all errors.

These are not blockers given this is best-effort cleanup logic.

backend/control_center/utils/ansible_formtter.py (1)

230-347: Port-status parsing is much more robust; address small lint and clarify semantics

The expanded logging and flag/state parsing in get_port_status_from_results looks solid and should make diagnosing weird ip link outputs much easier. A few small follow-ups:

1. Ruff F541 (f-string without placeholders)
   At line 313 you have an f-string with no interpolation:

   logger.debug(f"[PORT_STATUS] No explicit state found in output, checking flags in angle brackets")

   This can just be a plain string:

   - logger.debug(f"[PORT_STATUS] No explicit state found in output, checking flags in angle brackets")
   + logger.debug("[PORT_STATUS] No explicit state found in output, checking flags in angle brackets")

2. Non-existent ports now return False instead of None
   For the not_found_conditions branch you now return False, meaning “down”. That’s reasonable, but it is a behavior change from “unknown” (None). It’d be good to confirm all call sites (e.g., PortViewSet.sync) indeed want missing interfaces to be treated as down, and perhaps mention this explicitly in the docstring (e.g., “False if down or interface not found”).

3. Assumption about ip link output scope (optional)
   The parsing walks all output_lines without checking that a line belongs to port_name. This is fine as long as the underlying Ansible task runs ip link show dev {{ port_name }} (or similar) so only one interface is present. If that task is ever broadened to show multiple interfaces, you’ll want to filter lines by the interface name before interpreting state/flags.

backend/control_center/general/views.py (1)

691-763: Port.sync logging is much clearer; dedupe one error log line

The additional [PORT_SYNC] debug logs around playbook execution, parsed results, and DB updates significantly improve traceability of port sync behavior.

One small cleanup: on failure you log the same error twice—

logger.error(f"[PORT_SYNC] Failed to sync port {port.name}: {error_msg}")
logger.error(f"Failed to sync port {port.name}: {error_msg}")

You can safely drop the second line (or change its level if you want both a structured and a human-friendly variant) to avoid duplicate error entries. Optionally, you might also standardize on the [PORT_SYNC] prefix for all related log messages.

backend/control_center/ansible/roles/ovs-port-setup/tasks/setup_interface_monitoring.yml (2)

71-82: Add validation for PID read from lock file.

Line 73 reads the PID without validating its format. If the lock file contains invalid data, line 74 (kill -0 "$pid") may behave unexpectedly. Add a quick sanity check.

       # Function to check if script is already running
       check_lock() {
           if [ -f "$LOCK_FILE" ]; then
-              local pid=$(cat "$LOCK_FILE")
+              local pid=$(cat "$LOCK_FILE" 2>/dev/null)
+              [[ $pid =~ ^[0-9]+$ ]] || { log_message "ERROR: Invalid PID in lock file"; return 1; }
               if kill -0 "$pid" 2>/dev/null; then
                   log_message "WARNING: Monitor script already running (PID: $pid)"
                   exit 1
               else
                   # Lock file exists but process is dead, remove it
                   rm -f "$LOCK_FILE"
               fi
           fi
       }

---

36-44: Minor: Consider more robust interface status parsing.

Line 39 uses grep -q "state UP" to detect active interfaces. While this works for typical interface names, it could theoretically match interface names containing that string. For better reliability, consider using word boundaries or awk-based parsing.

       # Function to check if interface is up
       is_interface_up() {
           local interface="$1"
           # Check if interface exists and is UP
-          if ip link show "$interface" 2>/dev/null | grep -q "state UP"; then
+          if ip link show "$interface" 2>/dev/null | grep -qE '^\s+state UP'; then
               return 0  # Interface is up
           else
               return 1  # Interface is down
           fi
       }

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro